Skip to content

[26.0] Raise error when API client sends invalid parameter keys #22277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvdbeek merged 2 commits into from
Mar 28, 2026
Merged

[26.0] Raise error when API client sends invalid parameter keys #22277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec0df9d
Raise error when API client sends invalid parameter keys
mvdbeek Mar 27, 2026
79d98b1
Make exception more generic
mvdbeek Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/galaxy/tools/parameters/wrapped.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
Union,
)

from galaxy.exceptions import RequestParameterInvalidException
from galaxy.tools.parameters.basic import (
DataCollectionToolParameter,
DataToolParameter,
Expand Down Expand Up @@ -201,6 +202,8 @@ def process_key(incoming_key: str, incoming_value: Any, d: dict[str, Any]):
# Section / Conditional
input_name = key_parts[0]
subdict = d.get(input_name, {})
if not isinstance(subdict, dict):
raise RequestParameterInvalidException(f"Parameter '{incoming_key}' received conflicting value.")
d[input_name] = subdict
process_key("|".join(key_parts[1:]), incoming_value=incoming_value, d=subdict)

Expand Down
Loading