[26.0] Raise MessageException instead of generic Exception in rules_dsl#22285
Merged
mvdbeek merged 1 commit intogalaxyproject:release_26.0from Mar 30, 2026
Merged
Conversation
jmchilton
approved these changes
Mar 29, 2026
Member
jmchilton
left a comment
jmchilton
left a comment
There was a problem hiding this comment.
This file is just as usable outside the context of a web app or Galaxy - I don't think throwing MessageException from here is good design. I would find a Galaxy-concern to catch this in an translate it to a message exception here - maybe in the collections manager.
Member
Author
|
We will have to throw a known entity though (a catch all bare exception might be hiding "real" bugs), why not directly make it a more specific MessageException subclass ? |
Fixes galaxyproject#22100. When a regular expression fails to match in apply_regex(), the generic Exception was not caught by the API layer, resulting in an unhandled server error. Using MessageException ensures the error message is properly surfaced to users.
mvdbeek
force-pushed
the
rule_message_exception
branch
from
c064e0c to
3c29b7a
Compare
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22100. When a regular expression fails to match in apply_regex(), the generic Exception was not caught by the API layer, resulting in an unhandled server error. Using MessageException ensures the error message is properly surfaced to users and matches error handling for other scenarios in lib/galaxy/util/rules_dsl.py.
How to test the changes?
(Select all options that apply)
License