[26.0] Fix nested DatasetCollectionElement in dynamic options#22287
Merged
jmchilton merged 2 commits intogalaxyproject:release_26.0from Mar 29, 2026
Merged
Conversation
When a DatasetCollectionElement containing an LDDA or nested child collection (rather than an HDA) was used as a reference for dynamic option filtering, _get_ref_data() failed to normalize it into a list, causing "TypeError: 'DatasetCollectionElement' object is not iterable". Use DatasetCollectionElement.dataset_instances which correctly returns a list of dataset instances for all element types (HDA, LDDA, or nested collections). Fixes galaxyproject#22099
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
DatasetCollectionElementcontaining an LDDA or nested child collection (rather than an HDA) was used as a reference for dynamic option filtering,_get_ref_data()failed to normalize it into a list, causing "TypeError: 'DatasetCollectionElement' object is not iterable".Use
DatasetCollectionElement.dataset_instanceswhich correctly returns a list of dataset instances for all element types (HDA, LDDA, or nested collections).Fixes #22099
How to test the changes?
(Select all options that apply)
License