[26.0] Mark dataset collections as deleted when purging a history#22315
Merged
mvdbeek merged 1 commit intogalaxyproject:release_26.0from Mar 31, 2026
Merged
Conversation
When a history is purged, HDAs are correctly marked as deleted/purged but HDCAs (HistoryDatasetCollectionAssociation) were left with deleted=False. This caused API consumers to find collections from purged histories, leading to workflow failures when those collections' underlying datasets were purged. Fix both the synchronous (non-celery) and asynchronous (celery task) code paths to cascade the purge to dataset collections. Fixes galaxyproject#22312
ahmedhamidawan
approved these changes
Mar 31, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a history is purged, HDAs are correctly marked as deleted/purged but HDCAs (HistoryDatasetCollectionAssociation) were left with deleted=False. This caused API consumers to find collections from purged histories, leading to workflow failures when those collections' underlying datasets were purged.
Fix both the synchronous (non-celery) and asynchronous (celery task) code paths to cascade the purge to dataset collections.
Fixes #22312
How to test the changes?
(Select all options that apply)
License