[25.1] Discard rest of line in chunks in iter_start_of_line#22332
Merged
mvdbeek merged 2 commits intogalaxyproject:release_25.1from Apr 1, 2026
Merged
Conversation
Avoid reading the entire remainder of a line into memory when discarding, as some lines can be gigabytes in size.
mvdbeek
force-pushed
the
fix_readline_to_advance_iterator_25.1
branch
from
f24382c to
3358f8f
Compare
bernt-matthias
approved these changes
Mar 31, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid reading the entire remainder of a line into memory when discarding, as some lines can be gigabytes in size.
Fixes #22331
How to test the changes?
(Select all options that apply)
License