Skip to content

[26.0] Fix tool "Copy Link" generating broken /root?tool_id= URLs#22339

Merged
dannon merged 2 commits intogalaxyproject:release_26.0from
mvdbeek:fix_tool_copy_link_22338
Apr 2, 2026
Merged

[26.0] Fix tool "Copy Link" generating broken /root?tool_id= URLs#22339
dannon merged 2 commits intogalaxyproject:release_26.0from
mvdbeek:fix_tool_copy_link_22338

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Apr 1, 2026

Remove hardcoded root from the URL path in copyLink(), which caused 404s because /root was not a registered client route.

Also register /root as a client route for backward compatibility with existing bookmarks and shared links.

Fixes #22338

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Remove hardcoded `root` from the URL path in copyLink(), which caused
404s because /root was not a registered client route.

Also register /root as a client route for backward compatibility with
existing bookmarks and shared links.

Fixes galaxyproject#22338
@dannon
Copy link
Copy Markdown
Member

dannon commented Apr 1, 2026

One more fix to adjust the link in ToolLink.vue as well, but there's also a gotcha moving forward. On dev, the alias: "root" on the Home route was removed in b63b815 (the tool execution migration), so when this gets forward-merged the /root client route in buildapp.py will serve the SPA shell but the Vue Router won't match /root -- old bookmarks would silently land on a blank page. We'll need to either restore the alias on dev or drop the /root buildapp route there since it doesn't help without the client-side alias.

@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Apr 2, 2026

Thank you, should we merge ?

@dannon dannon merged commit f09e6b9 into galaxyproject:release_26.0 Apr 2, 2026
57 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Apr 2, 2026
@kostrykin
Copy link
Copy Markdown
Contributor

Thanks. Any idea when this fix should be available on Galaxy EU?

@bgruening
Copy link
Copy Markdown
Member

I can try updating today evening.

@ahmedhamidawan ahmedhamidawan modified the milestones: 26.1, 26.0 Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants