[26.0] Remove broken serialize_urls from HDASerializer#22358
Merged
mvdbeek merged 1 commit intogalaxyproject:release_26.0from Apr 6, 2026
Merged
[26.0] Remove broken serialize_urls from HDASerializer#22358mvdbeek merged 1 commit intogalaxyproject:release_26.0from
mvdbeek merged 1 commit intogalaxyproject:release_26.0from
Conversation
mvdbeek
force-pushed
the
remove-serialize-urls
branch
from
54773ef to
1a87341
Compare
The `serialize_urls` method has been broken in FastAPI context (raising NotImplementedError) because it used `self.url_for` without passing context. The client does not use these URLs — it hardcodes its own URL patterns in ContentItem.vue. The `urls` key was not included in any serializer view (summary, detailed, extended) and could only be fetched by explicitly requesting it.
mvdbeek
force-pushed
the
remove-serialize-urls
branch
from
1a87341 to
60863a4
Compare
davelopez
approved these changes
Apr 5, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
serialize_urlsmethod has been broken in FastAPI context (raising NotImplementedError) because it usedself.url_forwithout passing context. The client does not use these URLs — it hardcodes its own URL patterns in ContentItem.vue. Theurlskey was not included in any serializer view (summary, detailed, extended) and could only be fetched by explicitly requesting it.How to test the changes?
(Select all options that apply)
License