[25.1] Fix timestamp parsing in job import/export#22372
Merged
mvdbeek merged 1 commit intogalaxyproject:release_25.1from Apr 3, 2026
Merged
[25.1] Fix timestamp parsing in job import/export#22372mvdbeek merged 1 commit intogalaxyproject:release_25.1from
mvdbeek merged 1 commit intogalaxyproject:release_25.1from
Conversation
Use datetime.fromisoformat() instead of strptime with a rigid format that requires microseconds. When datetime.isoformat() produces timestamps without microseconds (e.g. "2026-04-02T14:28:40"), the strptime format "%Y-%m-%dT%H:%M:%S.%f" fails silently, leaving update_time/create_time as None on the restored model object. Also guard against None timestamps on the export side to prevent AttributeError when update_time or create_time is None. The try/except: pass was silently swallowing parse errors for 5 years, making it impossible to debug when timestamps failed to restore. Just check for key presence instead — if the value exists but is malformed, let it fail loudly. These fields are required by downstream code, so silently skipping them just delays the failure. Let KeyError or ValueError surface at the actual point of failure. Fixes galaxyproject#22371
natefoo
approved these changes
Apr 2, 2026
Member
natefoo
left a comment
natefoo
left a comment
There was a problem hiding this comment.
I will approve/merge any removal of silent try: except: pass without further analysis. 😆
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use datetime.fromisoformat() instead of strptime with a rigid format that requires microseconds. When datetime.isoformat() produces timestamps without microseconds (e.g. "2026-04-02T14:28:40"), the strptime format "%Y-%m-%dT%H:%M:%S.%f" fails silently, leaving update_time/create_time as None on the restored model object.
The try/except: pass was silently swallowing parse errors for 5 years, making it hard to debug when timestamps failed to restore. Just check for key presence instead — if the value exists but is malformed, let it fail loudly.
These fields are required by downstream code, so silently skipping them just delays the failure. Let KeyError or ValueError surface at the actual point of failure.
Fixes #22371
How to test the changes?
(Select all options that apply)
License