Skip to content

[26.0] Fix Content-Disposition header with trailing whitespace#22379

Merged
mvdbeek merged 1 commit intogalaxyproject:release_26.0from
mvdbeek:fix_content_disposition_trailing_whitespace
Apr 5, 2026
Merged

[26.0] Fix Content-Disposition header with trailing whitespace#22379
mvdbeek merged 1 commit intogalaxyproject:release_26.0from
mvdbeek:fix_content_disposition_trailing_whitespace

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Apr 4, 2026

Strip whitespace from target filename before building the Content-Disposition header to prevent h11 LocalProtocolError when dataset names contain trailing spaces.

Fixes GALAXY-MAIN-4KSCZZZ0015E3 / #22378

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Strip whitespace from target filename before building the
Content-Disposition header to prevent h11 LocalProtocolError
when dataset names contain trailing spaces.

Fixes GALAXY-MAIN-4KSCZZZ0015E3
@github-project-automation github-project-automation Bot moved this to Needs Review in Galaxy Dev - weeklies Apr 4, 2026
@github-actions github-actions Bot changed the title [26.0] Fix Content-Disposition header with trailing whitespace Fix Content-Disposition header with trailing whitespace Apr 4, 2026
@mvdbeek mvdbeek changed the base branch from dev to release_26.0 April 4, 2026 07:42
@github-actions github-actions Bot added this to the 26.1 milestone Apr 4, 2026
@github-actions github-actions Bot changed the title Fix Content-Disposition header with trailing whitespace [26.0] Fix Content-Disposition header with trailing whitespace Apr 4, 2026
@mvdbeek mvdbeek merged commit e9e7327 into galaxyproject:release_26.0 Apr 5, 2026
62 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Apr 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants