[26.0] Don't skip pypi-publish job if check-permissions was skipped#22442
Merged
ahmedhamidawan merged 1 commit intogalaxyproject:release_26.0from Apr 9, 2026
Merged
Conversation
In GitHub Actions, the default behaviour for any job is to run only if all its direct and indirect dependencies have a status of `success`. On a `release` event, the `check-permissions` job is skipped because of its `if:` condition. The `build-python-packages` job (which depends on `check-permissions`) runs anyway because it has an explicit `if:` condition which overrides the default behaviour. The `pypi-publish` job (which depends on `build-python-packages`) was instead skipped because id had no `if:` condition and one of its ancestors (`check-permissions`) was skipped.
nsoranzo
changed the title
pypi-publish job if check-permissions was skippedpypi-publish job if check-permissions was skipped
guerler
approved these changes
Apr 9, 2026
ahmedhamidawan
added
area/deployment
github_actions
ahmedhamidawan
merged commit 609f43e
into
galaxyproject:release_26.0
56 of 57 checks passed
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GitHub Actions, the default behaviour for any job is to run only if all its direct and indirect dependencies have a status of
success.On a
releaseevent, thecheck-permissionsjob is skipped because of itsif:condition.The
build-python-packagesjob (which depends oncheck-permissions) runs anyway because it has an explicitif:condition which overrides the default behaviour.The
pypi-publishjob (which depends onbuild-python-packages) was instead skipped because id had noif:condition and one of its ancestors (check-permissions) was skipped.How to test the changes?
(Select all options that apply)
License