fix: remove svg workaround, use itemProp instead #39385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
force-pushed
the
fix/react-head-document-title-alt
branch
from
d4613a8 to
c4c2e06
Compare
…just if tags are inserted/updated/removed
pieh
force-pushed
the
fix/react-head-document-title-alt
branch
from
c016924 to
04f10e4
Compare
pieh
force-pushed
the
fix/react-head-document-title-alt
branch
from
04f10e4 to
8b05d9b
Compare
pieh
changed the title
pieh
added a commit
that referenced
this pull request
Dec 22, 2025
…39382) * chore: add retries to flaky test * refactor: move guard earlier and colocate with comment * ci: disable browserslist console warnings These are nondeterministic and conflict with test output assertions * fix: ensure inserting <title> in <head> updates `document.title` In #39306 we introduced a workaround that wraps the Gatsby Head API elements in an `<svg>` wrapper. React under the hood creates these children elements in the "SVG" namespace. In the case of `<title>`, this is problematic because when we insert it into the real `<head>`, browsers (as far as we can tell) do not trigger an update of `document.title` because this only occurs for `<title>` nodes in the HTML namespace. A node's namespace is immutable, even when using `cloneNode()` or `importNode()`. The only way to "reset" the namespace is to recreate a node. * fix: remove svg workaround, use itemProp instead (#39385) * test: expand navigation tests to test if effects are applied and not just if tags are inserted/updated/removed * fix: remove svg workaround, use itemProp instead * fix: don't break rules of hooks in createElement patch --------- Co-authored-by: Michal Piechowiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Tests
Related Issues