Skip to content

Conversation

@indieloki
Copy link

Modify several internal functions like a MR for v2 library. Many people are using older versions of pgx and would appreciate a performance boost.

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (7e6e67b) to head (15cb2ed).
Report is 1 commits behind head on v1.

Files with missing lines Patch % Lines
dbscan/dbscan.go 79.16% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v1     #149      +/-   ##
==========================================
+ Coverage   82.63%   83.08%   +0.44%     
==========================================
  Files           5        5              
  Lines         432      538     +106     
==========================================
+ Hits          357      447      +90     
- Misses         60       76      +16     
  Partials       15       15              
Flag Coverage Δ
unittests 83.08% <87.50%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@georgysavva georgysavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this

@georgysavva georgysavva merged commit 567b819 into georgysavva:v1 Feb 27, 2025
10 checks passed
@georgysavva
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants