fix: Explicitly deprecate --started flag
#2515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
May 22, 2025
szokeasaurusrex
force-pushed
the
szokeasaurusrex/deprecate-finalize-started
branch
from
018aabe to
ebd9eda
Compare
The Sentry server [already ignores the value passed as `--started`](https://github.com/getsentry/sentry/blob/993bddbb73d9091fb949ad34578c7b28e0e3b8ab/src/sentry/api/endpoints/organization_release_details.py#L415-L534) to the `releases finalize` command. So, the option does not work as expected. Here, we explicitly mark the parameter as deprecated by logging a warning message stating that the value is ignored. We also stop sending the started date to the server. Fixes #2481
szokeasaurusrex
force-pushed
the
szokeasaurusrex/deprecate-finalize-started
branch
from
ebd9eda to
0dae679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sentry server already ignores the value passed as
--startedto thereleases finalizecommand. So, the option does not work as expected.Here, we explicitly mark the parameter as deprecated by logging a warning message stating that the value is ignored. We also stop sending the started date to the server.
Fixes #2481