ref: Only obtain max retry count once

[szokeasaurusrex]

With the current implementation, we attempt to retrieve the max retry count from the environment or from the ini file on every access, which could lead to the user being warned multiple times if an invalid value is supplied. Instead, we should only obtain this count once and store it in the Config

Depends on:

• fix: Don't error if invalid value supplied for max retries #2520

[Copilot]

Pull Request Overview

Introduce caching of the max retry count in Config to avoid repeated environment/INI lookups and warnings.

• Add a max_retries field to Config and initialize it once.
• Extract retry-count resolution into obtain_max_retry_count.
• Simplify get_max_retry_count to return the stored value and update Clone and tests.

Comments suppressed due to low confidence (4)

src/config.rs:806

• [nitpick] The tests only cover the default value path for max_retries. Add tests for environment variable override, INI file override, and invalid values to ensure all branches of obtain_max_retry_count are exercised.

max_retries: 0,

src/config.rs:527

• [nitpick] Consider renaming obtain_max_retry_count to get_max_retry_count_from_config or load_max_retry_count to align with the get_ prefix convention used by other helper functions.

fn obtain_max_retry_count(ini: &Ini) -> u32 {

src/config.rs:533

• The formatting string uses {MAX_RETRIES_ENV_VAR} as if it were a named placeholder but no named argument is provided. Change to a positional placeholder and pass the constant, for example: "Ignoring invalid {} environment variable: {}", MAX_RETRIES_ENV_VAR, e.

"Ignoring invalid {MAX_RETRIES_ENV_VAR} environment variable: {}",

src/config.rs:543

• Similar formatting issue here: use a positional placeholder and pass MAX_RETRIES_INI_KEY, e.g.: "Ignoring invalid {} ini key: {}", MAX_RETRIES_INI_KEY, e.

warn!("Ignoring invalid {MAX_RETRIES_INI_KEY} ini key: {}", e);