Sentry Express + Serverless losing transaction

[bvanderdrift]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

8.33.1

Framework Version

express 4.18.2, serverless-http 3.1.1

Link to Sentry event

https://amplify-30.sentry.io/issues/5951306644/?environment=development&project=4506665822584832&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&statsPeriod=1h&stream_index=0

Reproduction Example/SDK Setup

import {init, setupExpressErrorHandler} from '@sentry/node';
import {nodeProfilingIntegration} from '@sentry/profiling-node';

init({
  dsn: process.env.SENTRY_DSN,
  environment: 'development',

  integrations: [nodeProfilingIntegration()],

  tracesSampleRate: 1.0,
  profilesSampleRate: 1.0,
});

import express from 'express';
import serverless from 'serverless-http';

const app = express();

app.get('/debug-sentry/:test', (req, res) => {
  throw new Error('My first Sentry error!');
});

setupExpressErrorHandler(app);

export const handler = serverless(app);

Steps to Reproduce

Run the above file as a single file using serverless and serverless-offline plugin.

Then run curl http://localhost:3000/debug-sentry/hello

I've removed the serverless part and just started it as a raw express server using node index.js, which successfully logs the error, so it must be specific to the serverless-http wrapper.

I've also tried using @sentry/aws-serverless instead of @sentry/node which sadly logs nothing, presumably since express already handles the error.

Sentry 7 is logging errors correctly with the serverless + express combo.

Expected Result

Issue with URL, Headers & Query params

Actual Result

Also missing headers + query params

[Lms24]

Hey @bvanderdrift thanks for writing in! First off: Are you transpiling your application to CommonJS (require syntax) or does it stay ESM (import syntax) as you showed in your example? Please note that with SDK v8, you there are specific instructions to ESM where only importing on top if the file doesn't work anymore: https://docs.sentry.io/platforms/javascript/guides/node/install/

I'll try to reproduce this in the meantime

[Lms24]

To confirm because I'm not sure if I understood the problem correctly:

• Using v8 of the SDK with exactly the file you provided (i.e. with serverless): No errors are caught and the fields from the screenshot are missing
• Using v7 of the SDK with exactly the file you provided (i.e. with serverless): Errors are caught and all fields are present?

[Lms24]

Using v8 of the SDK with exactly the file you provided (i.e. with serverless): No errors are caught and the fields from the screenshot are missing

I cannot reproduce this fully. In my reproduction example, the error successfully sent to Sentry. However, I can reproduce that information about the request (url, status) as well as the transaction field are indeed missing. I'll dig a bit deeper to see what's going on here.

[Lms24]

Here's the link to my reproduction repo: https://github.com/Lms24/gh-sentry-javascript-13871-node-express-serverless-missing-data

Please take a look if there are any obvious differences!

I did make some adjustments from your initial example:

• Assuming you run your function in ESM (import syntax), I added an instrumentation.mjs file as explained in our docs and started it by adding NODE_OPTIONS: --import ./instrumentation.mjs to the serverless environment variables
• Removed profinling-node for now to reduce problem space

[bvanderdrift]

Sorry for confusion

• On v8: I do get the errors, just the transaction data is missing
• On v7: I do get the error, including transaction data.

Let me get back to you on the transpiling in a minute

[bvanderdrift]

This is the transpiled code, I'm actually not sure whether this is cjs or esm. Guess CJS since I see require.

"use strict";
var __importDefault = (this && this.__importDefault) || function (mod) {
    return (mod && mod.__esModule) ? mod : { "default": mod };
};
Object.defineProperty(exports, "__esModule", { value: true });
exports.handler = void 0;
var node_1 = require("@sentry/node");
var profiling_node_1 = require("@sentry/profiling-node");
(0, node_1.init)({
    dsn: process.env.SENTRY_DSN,
    environment: 'development',
    integrations: [(0, profiling_node_1.nodeProfilingIntegration)()],
    tracesSampleRate: 1.0,
    profilesSampleRate: 1.0,
});
var express_1 = __importDefault(require("express"));
var serverless_http_1 = __importDefault(require("serverless-http"));
var app = (0, express_1.default)();
app.get('/debug-sentry/:test', function (req, res) {
    throw new Error('My first Sentry error!');
});
(0, node_1.setupExpressErrorHandler)(app);
exports.handler = (0, serverless_http_1.default)(app);
//# sourceMappingURL=index.js.map