Skip to content

Support Prisma v6 #14793

Closed
1 of 1 issue completed
Parent:v9 Tasks
Closed
Feature
1 of 1 issue completed
Parent:#14225
@AbhiPrasad

Description

@AbhiPrasad
Member

Update

This is shipped! Docs here: https://docs.sentry.io/platforms/javascript/guides/node/configuration/integrations/prisma/

Description

From: getsentry/sentry-docs#12184

Prisma launched new version of 6.1.0 where tracing is not in previewFeature and some additional things need to be done to be able to trace application. Docs need to be updated

https://github.com/prisma/prisma/releases/tag/6.1.0

On our side we've been evaluating merging in #14624 for v9 (considering it seems to be a breaking change in some ways).

We need to figure out:

  1. Can we merge in 6.x bump for prisma instrumentation and still support 5.x? Ideally we can figure out how to support both at the same time so we support the max amount of users.
  2. How do we structure the docs (this issue: Outdated prisma documentation sentry-docs#12184) to make both 5.x and 6.x of the prisma integration work with 8.x and 9.x of the SDK.

Sub-issues

Sub-issues

1 of 1 Issues completed

Activity

added this to the 9.0.0 milestone on Dec 18, 2024
mydea

mydea commented on Jan 10, 2025

@mydea
Member

related: #14973

self-assigned this
on Jan 13, 2025
AbhiPrasad

AbhiPrasad commented on Jan 14, 2025

@AbhiPrasad
MemberAuthor

In terms of supporting both versions we have the following options.

  1. Only support 6.x for the upcoming v9 Sentry SDK. If folks want to use 5.x they can opt-in themselves by installing the package and flipping a flag in the integration.
  2. Support both 5.x and 6.x and conditionally switch for people. This means we have to include @prisma/instrumentation 5.x and 6.x as dependencies though :/
  3. Keep only supporting 5.x even in the upcoming v9 Sentry SDK. If folks want to use 6.x they can opt-in themselves by installing the package and flipping a flag in the integration.

Still debating through this, it's a little annoying that prisma instrumentation has such hard version constraints. I wish they separated it from the rest of prisma semvar.

All 3 approaches should be easy, but 1 and 3 will require the most possible manual work from users. 2 is all automatic, but we keep the deps for a while.

AbhiPrasad

AbhiPrasad commented on Jan 14, 2025

@AbhiPrasad
MemberAuthor

Updated our docs to make it clear that the SDK only supports 5.x atm: getsentry/sentry-docs#12324

AbhiPrasad

AbhiPrasad commented on Jan 14, 2025

@AbhiPrasad
MemberAuthor

Decision:

For v9 we are going to go ahead with 6.x support. We'll support 5.x in v8 and in v9 via a prismaIntegration(PrismaInstrumentationClass) API

aried3r

aried3r commented on Jan 14, 2025

@aried3r

@AbhiPrasad, to clarify. v8 supports 6.0.x of prisma, but not > 6.1, correct?

17 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Integration: prismaIssues related to Prisma support for the Sentry Node SDKPackage: nodeIssues related to the Sentry Node SDK

Projects

Status

No status

Development

No branches or pull requests

    Participants

    @aried3r@mydea@lforst@AbhiPrasad

    Issue actions

      Support Prisma v6 · Issue #14793 · getsentry/sentry-javascript