Description
Update
This is shipped! Docs here: https://docs.sentry.io/platforms/javascript/guides/node/configuration/integrations/prisma/
Description
From: getsentry/sentry-docs#12184
Prisma launched new version of 6.1.0 where tracing is not in previewFeature and some additional things need to be done to be able to trace application. Docs need to be updated
https://github.com/prisma/prisma/releases/tag/6.1.0
On our side we've been evaluating merging in #14624 for v9 (considering it seems to be a breaking change in some ways).
We need to figure out:
- Can we merge in
6.x
bump for prisma instrumentation and still support5.x
? Ideally we can figure out how to support both at the same time so we support the max amount of users. - How do we structure the docs (this issue: Outdated prisma documentation sentry-docs#12184) to make both
5.x
and6.x
of the prisma integration work with8.x
and9.x
of the SDK.
Sub-issues
Sub-issues
- Manage this item control shift u
Metadata
Metadata
Assignees
Type
Projects
Status
Relationships
Parent issue
Development
No branches or pull requests
Activity
fix: downgrade prisma and re-apply hono middleware
mydea commentedon Jan 10, 2025
related: #14973
AbhiPrasad commentedon Jan 14, 2025
In terms of supporting both versions we have the following options.
6.x
for the upcomingv9
Sentry SDK. If folks want to use5.x
they can opt-in themselves by installing the package and flipping a flag in the integration.5.x
and6.x
and conditionally switch for people. This means we have to include@prisma/instrumentation
5.x
and6.x
as dependencies though :/5.x
even in the upcomingv9
Sentry SDK. If folks want to use6.x
they can opt-in themselves by installing the package and flipping a flag in the integration.Still debating through this, it's a little annoying that prisma instrumentation has such hard version constraints. I wish they separated it from the rest of prisma semvar.
All 3 approaches should be easy, but 1 and 3 will require the most possible manual work from users. 2 is all automatic, but we keep the deps for a while.
AbhiPrasad commentedon Jan 14, 2025
Updated our docs to make it clear that the SDK only supports
5.x
atm: getsentry/sentry-docs#12324AbhiPrasad commentedon Jan 14, 2025
Decision:
For
v9
we are going to go ahead with6.x
support. We'll support5.x
inv8
and inv9
via aprismaIntegration(PrismaInstrumentationClass)
APIaried3r commentedon Jan 14, 2025
@AbhiPrasad, to clarify.
v8
supports6.0.x
of prisma, but not> 6.1
, correct?17 remaining items