Skip to content

fix(react-router): Conditionally add ReactRouterServer integration #16470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Jun 3, 2025

This PR conditionally instruments the server runtime of react-router, as there have been instrumentation issues.

  • Only instruments RR for node 20 (min version for react router) up to 20.19 (where we started seeing issues).
  • Exports the NODE_VERSION helper from @sentry/node

@chargome chargome self-assigned this Jun 3, 2025
@stevensacks
Copy link

Just to confirm, this doesn't work for Node 22?

@chargome
Copy link
Member Author

chargome commented Jun 4, 2025

@stevensacks no we disabled it for node 22 as well, just want to be conservative here in order not to break apps

EDIT: added support up to node 22.11

@chargome chargome requested a review from Lms24 June 4, 2025 07:44
@chargome chargome requested a review from RulaKhaled June 4, 2025 09:07
@chargome chargome merged commit 8657ded into develop Jun 4, 2025
162 checks passed
@chargome chargome deleted the cg-rm-rr-server-integration branch June 4, 2025 12:42
@stevensacks
Copy link

@chargome But LTS is 22.16, and we're using 22.14.

@chargome
Copy link
Member Author

chargome commented Jun 5, 2025

@stevensacks In this case you'll need to use #16481

Will cut a release today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants