ref(node): Improve span flushing #16577
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
reviewed
Jun 13, 2025
| this._flushTimeout = setTimeout(() => { | ||
| this.flush(); | ||
| }, 1); | ||
| if (!localParentId || this._sentSpans.has(localParentId)) { |
There was a problem hiding this comment.
should we also run cleanup on sent spans here (the _flushSentSpanCache method)?
The _sentSpans is checked for both flush and export, but only cleaned up in flush.
| }; | ||
| type CallbackFunction = () => unknown; | ||
| type DebounceOptions = { | ||
| maxWait?: number; |
Comment on lines
129
to
131
| const finishedSpans: ReadableSpan[] = this._finishedSpanBuckets.flatMap(bucket => | ||
| bucket ? Array.from(bucket.spans) : [], | ||
| ); |
There was a problem hiding this comment.
The intermediate array creation + flatMap usage is probably pretty expensive as well.
Suggested change
| const finishedSpans: ReadableSpan[] = this._finishedSpanBuckets.flatMap(bucket => | |
| bucket ? Array.from(bucket.spans) : [], | |
| ); | |
| const finishedSpans: ReadableSpan[] = []; | |
| for (const bucket of this._finishedSpanBuckets) { | |
| if (bucket) { | |
| for (const span of bucket.spans) { | |
| finishedSpans.push(span); | |
| } | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16416, slightly moving things around and making some small improvements to performance and logic (some not related to that PR but another improvement we noticed when BYK looked int this):
isSpanAlreadySenthas been called for every single span that ended, it is quite high impact, and meant a little bit of additional work (although it should not necessarily run too often, but still). Instead, we now simply check formap.has(id)which should be good enough for what we want to achieve, IMHO. We still clean up the sent spans when flushing, so old stuff should still go away eventually.For this I moved the already existing
debouncefunction from replay to core. We re-implement this in replay with a different setTimeout impl. which is needed for some angular stuff.