Skip to content

whisper: use global cache for sin/cos vals and Hann window #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

iboB
Copy link
Collaborator

@iboB iboB commented May 29, 2024

...also rename Hanning to Hann (named after Julius von Hann as per Wikipedia)

  • Hann window
    • Saves a computation for each run.
  • sin/cos tables:
    • slight optimization as it doesn't check and synchronize a static var
    • fix a (mostly benign) race condition where if two threads start computing them at the same time, both will end-up doing so

This at the cost of a very slightly slower boot time.

- also rename Hanning to Hann as it's named after Julius von Hann
 as per Wikipedia
@ggerganov ggerganov merged commit e130b66 into ggml-org:master May 29, 2024
49 checks passed
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
…2194)

- also rename Hanning to Hann as it's named after Julius von Hann
 as per Wikipedia
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
…2194)

- also rename Hanning to Hann as it's named after Julius von Hann
 as per Wikipedia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants