examples : add FFmpeg v7.0 support to ffmpeg-transcode.cpp #3038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFmpeg introduced a new channel layout API that uses `AVChannelLayout` interface in v6.0. It subsequently dropped the old bitmask-based API in v7.0. This updates decode_audio() to support the new channel layout API, so that we can compile `whisper-cli` and `whisper-server` with FFmpeg v7.0 or later. Tested on on Ubuntu 24.10 with FFmpeg v7.0.2. Signed-off-by: Fujimoto Seiji <[email protected]>
|
Note: I can confirm that this patch enables us to build $ # Compile test on Ubuntu 24.10 with FFmpeg v7.0.2
$ git checkout sf/ffmpeg-v7
$ cmake -B build -D WHISPER_FFMPEG=yes
$ cmake --build build
$ # Confirm that it works fine with FFmpeg v7
$ ./build/bin/whisper-cli -np -m models/ggml-tiny.bin jfk.opus
[00:00:00.000 --> 00:00:10.560] And so, my fellow Americans, ask not what your country can do for you, ask what you can do for your country.The API change I mentioned above was introduced by the following commits
I believe this changeset has already landed on Fedora 41 and Ubuntu 24.10. |
danbev
approved these changes
Apr 14, 2025
fujimotos
added a commit
to fujimotos/whisper.cpp
that referenced
this pull request
Apr 20, 2025
…3038) FFmpeg introduced a new channel layout API that uses `AVChannelLayout` interface in v6.0. It subsequently dropped the old bitmask-based API in v7.0. This updates decode_audio() to support the new channel layout API, so that we can compile `whisper-cli` and `whisper-server` with FFmpeg v7.0 or later. Tested on on Ubuntu 24.10 with FFmpeg v7.0.2. Signed-off-by: Fujimoto Seiji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3011
FFmpeg introduced a new channel layout API that uses
AVChannelLayoutinterface in v6.0. It subsequently dropped the old bitmask-based API
in v7.0.
This updates
decode_audio()to support the new channel layout API,so that we can compile
whisper-cliandwhisper-serverwith FFmpegv7.0 or later.