delete context.Clear and dependency to gorilla/context#151
Open
KeiichiHirobe wants to merge 1 commit intogin-contrib:masterfrom
Open
delete context.Clear and dependency to gorilla/context#151KeiichiHirobe wants to merge 1 commit intogin-contrib:masterfrom
KeiichiHirobe wants to merge 1 commit intogin-contrib:masterfrom
Conversation
KeiichiHirobe
force-pushed
the
delete-gorilla-context
branch
from
03fd673 to
2f45631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defer context.Clear(c.Request)does not make sense now because this library depends ongithub.tiyicn.workers.dev/gorilla/sessions v1.2.0.So delete
defer context.Clear(c.Request)and,go mod tidyto delete dependency togorilla/context(UPDATE: #131 made a new dependency to github.com/wader/gormstore/v2@v2.0.0, which depends on gorilla context, sogorilla/contextstill exists ingo.sum).If version is lower than
v1.2.0, we need this code to avoid memory leak.ref: gorilla/sessions#175
Resolve: #92