Downgrade to sqlite3 v1#187
Closed
DemonTPx wants to merge 1 commit intogin-contrib:masterfrom
Closed
Conversation
Contributor
|
LGTM |
Member
|
Downgrade to v1.14.16 version. |
tie
added a commit
to tie/PufferPanel
that referenced
this pull request
Mar 9, 2023
This change bumps go-sqlite3 version in go.mod. Note that go-sqlite3 is actually at v1 version, the v2 is an accident as written in README. >Latest stable version is v1.14 or later, not v2. > >NOTE: The increase to v2 was an accident. There were no major changes or >features. This change fixes mattn/go-sqlite3#822 As a side effect, we also upgrade gin-contrib/sessions to the latest commit for gin-contrib/sessions#187 There were no major changes since v0.0.5 release aside from minor dependency version bumps. gin-contrib/sessions@v0.0.5...189b96f
LordRalex
pushed a commit
to pufferpanel/pufferpanel
that referenced
this pull request
Apr 9, 2023
This change bumps go-sqlite3 version in go.mod. Note that go-sqlite3 is actually at v1 version, the v2 is an accident as written in README. >Latest stable version is v1.14 or later, not v2. > >NOTE: The increase to v2 was an accident. There were no major changes or >features. This change fixes mattn/go-sqlite3#822 As a side effect, we also upgrade gin-contrib/sessions to the latest commit for gin-contrib/sessions#187 There were no major changes since v0.0.5 release aside from minor dependency version bumps. gin-contrib/sessions@v0.0.5...189b96f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've upgraded/downgraded the go-sqlite3 package to the v1 branch. This seems weird, but the maintainer of the go-sqlite3 package made the v2.* versions accidentally. (See https://github.com/mattn/go-sqlite3/blob/master/README.md)
The github.com/wader/gormstore/v2 package also depended on this v2.* branch of the go-sqlite3 package, but was fixed in v2.0.1.
The v2.0.3 version of go-sqlite3 is old and has some problems, which are fixed in later v1.* versions.
The v0.0.5 version of this package makes it unable to use the newer v1.* versions of go-sqlite3. I had to downgrade to v0.0.4 to be able to do so. This PR should fix that problem.
Thanks,
Bert