Added guard to split not to get out of bounds exception when testing#288
Merged
appleboy merged 3 commits intogin-contrib:masterfrom May 22, 2025
Merged
Added guard to split not to get out of bounds exception when testing#288appleboy merged 3 commits intogin-contrib:masterfrom
appleboy merged 3 commits intogin-contrib:masterfrom
Conversation
appleboy
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current test code we're accessing the splitted slice without checking if split returned a slice long enough.
This patch checks the len of s is enough to access s[1]