Rust: extract hasImplementation on functions and consts
#19649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 3, 2025 10:41
When skipping bodies in library code, we lose the information whether a body was originally present. This can be important, for example when determining whether a trait method has a default implementation. With this change that information can be recovered via the `hasImplementation` predicate.
redsun82
force-pushed
the
redsun82/rust-has-implementation
branch
from
f88949a to
1110fea
Compare
redsun82
changed the title
hasImplementation on functionshasImplementation on functions and consts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skipping bodies in library code, we were losing the information whether a body was originally present. This can be important, for example when determining whether a trait method has a default implementation. For
Constwe just now extract the body as well in library code.With this change that information can now be recovered via the
hasImplementationpredicate.Finally, the above uncovered a bug in the rustgen templates, where a detached predicate property would not be handled correctly. That is fixed now.