Remove Copilot --share flag; use JS log parser for output preview#17315
Remove Copilot --share flag; use JS log parser for output preview#17315
--share flag; use JS log parser for output preview#17315Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…tead Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
--share flag; use JS log parser for output preview
…sation-md-support
There was a problem hiding this comment.
Pull request overview
This PR removes the Copilot CLI's --share flag that was used to generate a conversation.md file, aligning Copilot's output processing with other agentic engines (Claude/Codex/Gemini) by using the shared JavaScript log parser. The change ensures Copilot produces both a core.info plain-text summary and a generateCopilotCliStyleSummary step summary, consistent with the other engines.
Changes:
- Removed
--shareflag and conversation.md path handling from Copilot engine execution - Removed conversation.md fast-path logic from log parser bootstrap
- Removed associated test for the removed behavior
- Regenerated golden files and lock files to reflect the updated Copilot CLI invocations
Reviewed changes
Copilot reviewed 110 out of 110 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/copilot_engine_execution.go | Removed 6 lines that added the --share flag with conversation.md path to Copilot CLI arguments |
| actions/setup/js/log_parser_bootstrap.cjs | Removed 35 lines of conversation.md fast-path logic that short-circuited normal log parsing for Copilot |
| actions/setup/js/log_parser_bootstrap.test.cjs | Removed 43 lines of test code validating the removed conversation.md transformation behavior |
| Multiple .lock.yml files | Updated generated workflow files removing --share flag from all Copilot CLI invocations |
| Golden test files | Updated expected outputs removing --share flag from compiled workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🧪 Smoke Project is now testing project operations... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🧪 Smoke Temporary ID is now testing temporary ID functionality... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✅ Smoke Project completed successfully. All project operations validated. |
|
Smoke test results (run 22246003472):
|
|
🤖 Smoke test §22246003495 —
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR cleanly removes the --share flag from the Copilot CLI invocation and replaces the conversation.md-based preview with the standard JS log parser. The change simplifies the pipeline and removes a Copilot-specific code path, making log parsing uniform across all engines. LGTM!
📰 BREAKING: Report filed by Smoke Copilot
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
@copilot update the copilot javascript log parser to support the current log format. See run https://github.com/github/gh-aw/actions/runs/22246003495 |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated the parser in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
The Copilot engine was bypassing the shared JS log parser by using the CLI's
--shareflag to generate aconversation.mdfile and writing it directly to the step summary — skipping both thecore.infopreview and the structured Copilot-CLI-style summary used by all other engines.Changes
copilot_engine_execution.go: Remove--share /tmp/gh-aw/sandbox/agent/logs/conversation.mdfrom the Copilot CLI argumentslog_parser_bootstrap.cjs: Remove theconversation.mdfast-path that short-circuited the parser when the file was presentlog_parser_bootstrap.test.cjs: Remove the test covering the removed behaviorparse_copilot_log.cjs: Handlereasoning_textin the debug log format — the current Copilot CLI (v0.0.412+) uses Claude models that emit extended thinking alongside tool calls; this field is now captured as a text entry so it appears in both the step summary Reasoning section and thecore.infoplain-text previewparse_copilot_log.test.cjs: Add a test forreasoning_textparsing in the debug log formatmake recompileand-updateto remove--sharefrom compiled workflowsAfter this change, Copilot uses the same
parse_copilot_log.cjs→runLogParserpath as Claude/Codex/Gemini, producing both acore.infoplain-text summary and agenerateCopilotCliStyleSummarystep summary.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.