Skip to content

Tool tests could be a bit more strict in their assertions #83

Open
@williammartin

Description

@williammartin

Description

On #82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we call the API with the expected values, only stubbing a response value:

mock.WithRequestMatchHandler(
mock.PostReposIssuesByOwnerByRepo,
mockResponse(t, http.StatusCreated, mockIssue),
),

We should maybe look to tighten these tests up a bit, it would be very easy to break the tool implementations without knowing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions