Skip to content

Conversation

koic
Copy link
Contributor

@koic koic commented Apr 29, 2021

Follow rubocop/rubocop#7868.

The legacy Cop::Cop API is soft deprecated and this PR use new Cop::Base API instead.

maintain any RuboCop extensions, as the legacy API will be removed in
RuboCop 2.0.

https://metaredux.com/posts/2020/10/21/rubocop-1-0.html

This new API requires RuboCop 0.87 or higher.
https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06

Denpendency version of s.add_dependency "rubocop" does not need to be updated in the gemspec if #86 has been merged first.

Follow rubocop/rubocop#7868.

The legacy `Cop::Cop` API is soft deprecated and this PR use
new `Cop::Base` API instead.

> maintain any RuboCop extensions, as the legacy API will be removed in
> RuboCop 2.0.

https://metaredux.com/posts/2020/10/21/rubocop-1-0.html

This new API requires RuboCop 0.87 or higher.
https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06

Denpendency version of `s.add_dependency "rubocop"` does not need to be
updated in the gemspec if github#86 has been merged first.
@koic koic force-pushed the use_cop_base_api branch from 54d65ef to 0bc4a31 Compare June 27, 2022 17:26
@composerinteralia
Copy link
Member

Thanks!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@composerinteralia composerinteralia merged commit 3d1ad77 into github:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants