Skip to content

enable testing of performance tests #524

Closed
@yarikoptic

Description

@yarikoptic

according to https://codecov.io/gh/gitpython-developers/GitPython/tree/94ca83c6b6f49bb1244569030ce7989d4e01495c/git/test/performance those aren't executed during travis run ATM (I guess because performance is not tests_performance or smth like that). But better be done after #522 is merged to see the effect

Activity

ankostis

ankostis commented on Oct 2, 2016

@ankostis
Contributor

@Byron what's the reasons for having these performance TCs disabled on Travis?

Byron

Byron commented on Oct 9, 2016

@Byron
Member

@yarikoptic @ankostis They are disabled to get travis feedback faster. Right now, the benchmark numbers produced by the performance tests are not stored or analysed in any way, thus a performance regression will not be discovered by them. If the two of you believe it would still be good to have thanks to even increased coverage, please feel free to put them in.

yarikoptic

yarikoptic commented on Oct 9, 2016

@yarikoptic
ContributorAuthor

On Sun, 09 Oct 2016, Sebastian Thiel wrote:

@yarikoptic @ankostis They are disabled to get travis feedback faster.
Right now, the benchmark numbers produced by the performance tests are not
stored or analysed in any way, thus a performance regression will not be
discovered by them. If the two of you believe it would still be good to
have thanks to even increased coverage, please feel free to put them in.

FWIW on my laptop it takes only 15sec

nosetests git/test/performance 15.04s user 1.12s system 102% cpu 15.753 total

and IIRC it does improve coverage a bit (besides its own tests code), so I
thought it would be worthwhile, to also make sure that that performance
measuring code doesn't get stale.

ghost added a commit that references this issue on Oct 10, 2016
added 2 commits that reference this issue on Oct 11, 2016
e355275
aafde7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @yarikoptic@Byron@ankostis

        Issue actions

          enable testing of performance tests · Issue #524 · gitpython-developers/GitPython