Skip to content

Parse rejected deletes. #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

uri-canva
Copy link
Contributor

Successful branch deletions look like

-	:refs/heads/test-delete	[deleted]

however rejected branch deletions look like

!	(delete):refs/heads/test-delete	[rejected] (stale info)

for some reason. Parse those as well.

@codecov-io
Copy link

codecov-io commented Sep 28, 2019

Codecov Report

Merging #929 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
- Coverage   93.61%   93.47%   -0.15%     
==========================================
  Files          59       59              
  Lines        9794     9582     -212     
==========================================
- Hits         9169     8957     -212     
  Misses        625      625
Impacted Files Coverage Δ
git/test/test_remote.py 97.84% <100%> (ø) ⬆️
git/objects/tree.py 59.06% <0%> (-0.94%) ⬇️
git/index/util.py 90.69% <0%> (-0.61%) ⬇️
git/refs/log.py 93.07% <0%> (-0.59%) ⬇️
git/index/typ.py 96.82% <0%> (-0.58%) ⬇️
git/test/lib/helper.py 85.46% <0%> (-0.49%) ⬇️
git/test/test_util.py 90.34% <0%> (-0.33%) ⬇️
git/objects/base.py 95.83% <0%> (-0.33%) ⬇️
git/refs/tag.py 96.66% <0%> (-0.31%) ⬇️
git/refs/reference.py 95.74% <0%> (-0.26%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359a7e0...dc8db67. Read the comment docs.

@Byron
Copy link
Member

Byron commented Sep 28, 2019

Fantastic! Thanks so much!

@Byron Byron added this to the v3.0.3 - Bugfixes milestone Sep 28, 2019
@Byron Byron merged commit fdb1dc7 into gitpython-developers:master Sep 28, 2019
@uri-canva uri-canva deleted the rejected-delete branch September 28, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants