Skip to content

Fixed VK #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Fixed VK #707

merged 1 commit into from
Apr 18, 2025

Conversation

nevo-david
Copy link
Contributor

@nevo-david nevo-david commented Apr 18, 2025

  • feat: vk provider
  • feat: vk refresh token

Summary by CodeRabbit

  • New Features
    • Improved token refresh process for VK integration, now dynamically calculating token expiry and including updated user information after refresh.
  • Bug Fixes
    • Expiry time for tokens is now accurately set based on VK's response instead of a fixed duration.
  • Style
    • Minor code cleanup in post handling for improved readability.

Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
gitroom ⬜️ Ignored (Inspect) Apr 18, 2025 2:09pm
postiz ⬜️ Ignored (Inspect) Apr 18, 2025 2:09pm

@nevo-david nevo-david merged commit ee0fa5b into main Apr 18, 2025
4 of 5 checks passed
Copy link

coderabbitai bot commented Apr 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes focus on the VK provider integration, specifically rewriting the refreshToken method to handle refresh tokens that include both a token and a device ID separated by "&&&&". The new implementation parses these components, constructs appropriate payloads, and makes two sequential POST requests: one to refresh tokens via VK's OAuth2 endpoint, and another to retrieve user information. The expiry time for tokens is now dynamically calculated from the OAuth response. The authenticate method is updated to match this expiry calculation and refresh token handling. Additionally, a minor syntax cleanup was performed in the post method.

Changes

File(s) Change Summary
libraries/nestjs-libraries/src/integrations/social/vk.provider.ts Rewrote refreshToken to parse combined refresh token/device ID, update payloads, fetch user info, and calculate expiry dynamically. Updated authenticate to use dynamic expiry and new refresh token format. Cleaned up syntax in post method.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant VkProvider
    participant VK_OAuth2
    participant VK_API

    Client->>VkProvider: Call refreshToken(combined_refresh_token)
    VkProvider->>VkProvider: Split refresh_token into token and device_id
    VkProvider->>VK_OAuth2: POST /token (with refresh_token, device_id, client_id, etc.)
    VK_OAuth2-->>VkProvider: Respond with new access_token, refresh_token, expires_in
    VkProvider->>VK_API: POST /users.get (with access_token)
    VK_API-->>VkProvider: Respond with user info
    VkProvider-->>Client: Return AuthTokenDetails (user info, tokens, expiry)
Loading

Poem

In the warren of code, a VK hop,
Tokens split and twined, device IDs atop.
With expiry now ticking from OAuth’s own clock,
User info fetched in a seamless unlock.
A syntax nibble here, a refresh there—
Rabbits keep integrations running with flair! 🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e74b52 and 7f82e6c.

📒 Files selected for processing (1)
  • libraries/nestjs-libraries/src/integrations/social/vk.provider.ts (4 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai bot mentioned this pull request May 27, 2025
arampersand pushed a commit to arampersand/flowsupply that referenced this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant