-
Notifications
You must be signed in to change notification settings - Fork 3.3k
(fix) Make Caddyfile use /uploads/ as default root but variable UPLOAD_DIRECTORY when set #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…D_DIRECTORY when set
@BrutalBirdie is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe Caddyfile configuration for the Changes
Possibly related issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
What kind of change does this PR introduce?
It improves the handling of the Caddyfile to catch user errors when setting the
UPLOAD_DIRECTORY
to a local path.Without this change, users will have to change the Caddyfile manually.
This way, nothing needs to be done, except set the
UPLOAD_DIRECTORY
variable when Caddy gets started.Why was this change needed?
Because there is/was no documentation for this "issue" and why document more when you can improve and make it prevent user erros.
Other information:
None
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;
Summary by CodeRabbit