Bump to-float32 package #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades to-float32 package and uses the new version to improve the performance when drawing.
This was referenced Jun 29, 2021
|
💃 |
archmoj
reviewed
Jun 29, 2021
| positionBuffer({ | ||
| data: f32.float(positions), | ||
| var float_data = f32.float32(positions) | ||
| state.positionBuffer({ |
There was a problem hiding this comment.
state is not defined!
Fixed in 42113ea
archmoj
reviewed
Jun 29, 2021
| positionFractBuffer({ | ||
| data: f32.fract(positions), | ||
| var frac_data = f32.fract32(positions, float_data) | ||
| state.positionFractBuffer({ |
There was a problem hiding this comment.
Also here state is not defined!
Fixed in 42113ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to-float32 package and uses the new version to improve the performance when drawing.
You can see the to-float32 package changes here
Other packages PRs: here, here
@archmoj
cc: @alexcjohnson