Skip to content

Pass text align opts #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2016
Merged

Pass text align opts #2

merged 2 commits into from
Oct 24, 2016

Conversation

etpinard
Copy link
Member

First of 3 PRs on the way to fixing plotly/plotly.js#198

@monfera

@etpinard
add ability to pass option object
82400b8 
- for now handling only 'textAlign'
@etpinard
4.1.0
ff0cd57
etpinard added a commit to gl-vis/gl-plot2d that referenced this pull request Oct 21, 2016
@etpinard
pass textAlign: 'center' option to text-cache for axis labels
c1996b4 
- using gl-vis/text-cache#2
@etpinard etpinard mentioned this pull request Oct 21, 2016
Merged
@monfera
Copy link
Member

monfera commented Oct 21, 2016

@etpinard nice, looks great, I can only approve. The underlying vectorize-text module recently got new config capability e.g. bold / italic; as you did it in this set of PRs the only thing to be aware of is that caching needs to be separate for different geometry options.

@etpinard etpinard merged commit 006e403 into master Oct 24, 2016
@etpinard etpinard deleted the pass-text-align-opts branch October 24, 2016 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etpinard @monfera