service/dap: Change event reason to "entry" when stopping on entry#1976
Merged
derekparker merged 1 commit intogo-delve:masterfrom Apr 1, 2020
Merged
service/dap: Change event reason to "entry" when stopping on entry#1976derekparker merged 1 commit intogo-delve:masterfrom
derekparker merged 1 commit intogo-delve:masterfrom
Conversation
polinasok
changed the title
Collaborator
Author
|
cc @eliben |
polinasok
changed the title
Collaborator
Author
|
Matching PR to vscode-go was accepted as well: microsoft/vscode-go#3150. |
RenovZ
pushed a commit
to RenovZ/delve
that referenced
this pull request
Mar 25, 2022
…e#1976) Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
abner-chenc
pushed a commit
to loongson/delve
that referenced
this pull request
Mar 1, 2024
…e#1976) Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing code matched vscode-go, setting reason to 'breakpoint', but that's misleading and according to the spec, there is a special option for entry. Use that option. This impacts what is displayed in the UI ('paused on breakpoint' vs 'paused on entry').
Updates #1515