Skip to content

fix slogLogger to support ParameterizedQueries Config #7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinzhu merged 1 commit into from
Sep 8, 2025
+8 −0
Merged

fix slogLogger to support ParameterizedQueries Config #7574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions logger/slog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,11 @@ func (l *slogLogger) Trace(ctx context.Context, begin time.Time, fc func() (sql
})
}
}

// ParamsFilter filter params
func (l *slogLogger) ParamsFilter(ctx context.Context, sql string, params ...interface{}) (string, []interface{}) {
if l.Parameterized {
return sql, nil
}
return sql, params
}
Comment on lines +92 to +98
Copy link
Copy Markdown
Contributor

@propel-code-bot propel-code-bot Bot Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BestPractice]

[CodeDuplication] The ParamsFilter method is nearly identical to the existing implementation in logger/logger.go. The only difference is the field name (l.Parameterized vs l.Config.ParameterizedQueries). Consider extracting this logic to a shared utility function or ensuring consistent field naming across logger implementations to avoid code duplication.

Loading