Support any type that implements fmt.Stringer in ObjectIdHex and IsObjectIdHex instead of simple string #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jectIdHex instead of simple string
|
I don't believe that would work. You need to implement the I suggest to revisit this PR or even close it. |
Contributor
|
@fatih is spot on. |
wpjunior
pushed a commit
to wpjunior/mgo
that referenced
this pull request
Aug 12, 2018
* Add 3.6 user authenticationRestrictions * Add struct-field comment * Add struct-field comment go-mgo#2 * Add struct-field comment go-mgo#3 * Add documentation link * Fix comment * Fix comment go-mgo#2 * add to README.md * add to README.md go-mgo#2 * add to README.md go-mgo#3 * Add positive/negative authentication restrictions user test * Use denyUser for negative test * Correct message * Fix error match * Fix close on nil/closed session * Simplify test, last change :) * Simplify test, last change :) go-mgo#2 * Simplify test, last change :) go-mgo#3 * Fix := error
wpjunior
pushed a commit
to wpjunior/mgo
that referenced
this pull request
Aug 12, 2018
wpjunior
pushed a commit
to wpjunior/mgo
that referenced
this pull request
Aug 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows using of any type that implements fmt.Stringer in ObjectIdHex and IsObjectIdHex functions.
Example:
If we have type
type UserId string, we have to typecast UserId to string.With this change we simply pass the UserId object without typecast.