Feat: Add the PagePool.TryGet method while it returns an error for processing.

[zeoxisca]

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check

PagePool Change

• PagePool/BrowserPool Add the MustGet method to replace Get, and Get returns an error for processing
• Modify CleanUp method to prevent stucking

The PagePool.Get can now only accept create func() *Page as input, so there is no way to output the error that may exist in the create func other than using a closure or using recover, and it is inconvenient for users in a multi-routine environment to perform logical processing based on the actual error that occurred. I added the PagePool.MustGet method to solve this. However, I'm not sure whether this change would be in line with the original design.

Besides, PagePool.CleanUp may stuck while pp is not full (forget/panic to Put, etc). I also think this might be an issue when using PagePool. Use select to prevent stucking

[ysmood]

👍🏼

[ysmood]

Suggested change

	func (pp PagePool) TryGet(create func() (*Page, error)) (*Page, error) {
	func (pp PagePool) Get(create func() (*Page, error)) (*Page, error) {

Could you help to rename the Get to MustGet? Same for the browser pool.

[zeoxisca]

I've tried it before, but MustGet is restricted to be implemented in must.go because of the lint.
Changing to PagePool.Get also could involve the chrome-extensions. I'll rename it if these changes don't impact a lot.

[ysmood]

Sure, move the MustGet to must.go file. Keep your Get one in the utils.go file.

[zeoxisca]

Done

[ysmood]

LGTM!