Skip to content

conncheck should be optional #996

Closed
@methane

Description

@methane
Member

Issue description

connCheck added in #934 allocates several objects.

./conncheck.go:22:16: leaking param: c
./conncheck.go:24:3: moved to heap: n
./conncheck.go:25:3: moved to heap: err
./conncheck.go:26:3: moved to heap: buff
./conncheck.go:37:18: func literal escapes to heap

Allocating 5 objects every time connection is checked out from the sql.DB is not good for performance. This can be a big performance regression.

Additionally, users may want to check liveness only after long idle.
Or Aurora users want to check SELECT @@innodb_read_only to detect fail over. ref.

Activity

renthraysk

renthraysk commented on Sep 5, 2019

@renthraysk

buff could be shifted to inside the closure.

julienschmidt

julienschmidt commented on Sep 6, 2019

@julienschmidt
Member

We can move even a bit more inside the closure: c016c38

added this to the v1.6.0 milestone on Nov 8, 2019
modified the milestones: v1.6.0, v1.5.0 on Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @methane@julienschmidt@renthraysk

      Issue actions

        conncheck should be optional · Issue #996 · go-sql-driver/mysql