Skip to content

x/pkgsite: package removal request for github.com/rigdev/rig/cmd/rig #64279

Closed
@andersjohnsen

Description

@andersjohnsen

What is the path of the package that you would like to have removed?

github.com/rigdev/rig/cmd/rig

Are you the owner of this package?

Yes, I'm the owner/admin at github.com/rigdev/rig

What is the reason that you could not retract this package instead?

The path github.com/rigdev/rig/cmd/rig was integrated into github.com/rigdev/rig, that now hosts a shared go.mod. The old cache makes some use-cases problematic (e.g. go install github.com/rigdev/rig/cmd/rig@latest).

Activity

added this to the Unreleased milestone on Nov 20, 2023
bcmills

bcmills commented on Nov 20, 2023

@bcmills
Contributor

@andersjohnsen, removing the package from pkg.go.dev will not change the behavior of go install github.com/rigdev/rig/cmd/rig@latest. You need to use a retract directive instead. (See https://go.dev/ref/mod#go-mod-file-retract.)

You can do that by creating a commit (possibly outside of the main branch) that restores cmd/rig/go.mod and retracts all versions of that module, and then applying an explicit release or pre-release tag (like cmd/rig/v0.0.0-retracted) to that commit so that go install can find it when it looks for retractions.

added
WaitingForInfoIssue is not actionable because of missing required information, which needs to be provided.
on Nov 20, 2023
andersjohnsen

andersjohnsen commented on Nov 21, 2023

@andersjohnsen
Author

Aha, thank you. I'll try that out! Any chance you have a link for a repository that has applied the same trick, for reference?

andersjohnsen

andersjohnsen commented on Nov 21, 2023

@andersjohnsen
Author

I went ahead and did as you suggested, and I can verify the following now works:

go install github.com/rigdev/rig/cmd/rig@latest

🎉

It still fails for @main though:

❯ go install github.com/rigdev/rig/cmd/rig@main
go: downloading github.com/rigdev/rig/cmd/rig v0.0.0-20230906091239-bd04b590bcf0
go: downloading github.com/rigdev/rig v1.5.0-rc.2.0.20231121055207-02f86f610fa4
[...]
go: found github.com/rigdev/rig/cmd/common in github.com/rigdev/rig v1.4.0
ambiguous import: found package github.com/rigdev/rig/cmd/rig in multiple modules:
        github.com/rigdev/rig v1.4.0 (/home/anders/go/pkg/mod/github.com/rigdev/rig@v1.4.0/cmd/rig)
        github.com/rigdev/rig/cmd/rig v0.0.0-20230906091239-bd04b590bcf0 (/home/anders/go/pkg/mod/github.com/rigdev/rig/cmd/rig@v0.0.0-20230906091239-bd04b590bcf0)

Is there a step I missed, or is it a question of cache invalidation propagation?

Thank you!,
Anders

bcmills

bcmills commented on Nov 21, 2023

@bcmills
Contributor

That may be another symptom of #39007 / #49146, or it may be related to #61415.

@suzmue, could you check the cached result for the main branch of this module, and perhaps remove any stale origin metadata?

removed
WaitingForInfoIssue is not actionable because of missing required information, which needs to be provided.
on Nov 21, 2023
suzmue

suzmue commented on Dec 8, 2023

@suzmue
Contributor

Yes it appears there was a cached result for the main branch, which I have removed. This appears to be a similar instance of #49146, where the proxy is serving a stale mapping for a branch name when more recent fetches are failing.

@andersjohnsen go install github.com/rigdev/rig/cmd/rig@main should work now. Please feel free to reopen if it does not!

4 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @andersjohnsen@hyangah@bcmills@suzmue@gopherbot

      Issue actions

        x/pkgsite: package removal request for github.com/rigdev/rig/cmd/rig · Issue #64279 · golang/go