Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

feat: new in slice matcher #582

Closed
wants to merge 1 commit into from
Closed

feat: new in slice matcher #582

wants to merge 1 commit into from

Conversation

MakDon
Copy link

@MakDon MakDon commented Aug 24, 2021

This PR provides a new matcher that returns true if the given value Eq one of the want elements.

// Example usage:
m := In([]int{1,2})
m.Matches(1) // returns true
m.Matches(2) // returns true
m.Matches(3) // returns false

@MakDon MakDon requested a review from codyoss as a code owner August 24, 2021 14:45
@codyoss
Copy link
Member

codyoss commented Sep 17, 2021

@MakDon Can you please open up an issue for discussion about adding such a feature. Thanks.

@codyoss codyoss added status: do not merge status: needs more info This issue need more information from the author. labels Sep 17, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@MakDon
Copy link
Author

MakDon commented Sep 17, 2021

@codyoss Hi codyoss, thanks for your review.

I've opened up an issue #590 for further discussion.

@codyoss codyoss removed the status: needs more info This issue need more information from the author. label Oct 1, 2021
@codyoss
Copy link
Member

codyoss commented Oct 1, 2021

Closing this for now until discussion on the issue has settled. I will reopen if we decide to move forward with these changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants