net/http: use consistent IDNA processing for dial target and Host header - #253
Open
kingljl wants to merge 4 commits into
Open
net/http: use consistent IDNA processing for dial target and Host header#253kingljl wants to merge 4 commits into
kingljl wants to merge 4 commits into
Conversation
Updated IDNA processing to use idna.Lookup.ToASCII for host conversion, ensuring consistency with net/http Transport.
Add TestAuthorityAddrIDNAMapping to verify IDNA processing
Added IDNA processing for host in request handling.
Add a test for IDNA mapping in EncodeHeaders function.
Contributor
|
This PR (HEAD: e5588eb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/802060. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
with mapping) when computing the Host / :authority header. Add the
idnaASCIIHostPort helper.
for the HTTP/2 dial target, so the connection pool key, dialed
address, and header agree.
Fixes golang/go#80417