http2: fix client GOAWAY to send valid Last-Stream-ID - #256
Open
waterWang wants to merge 1 commit into
Open
Conversation
Client-initiated GOAWAY must have Last-Stream-ID in the server's stream-id space (even) or 0. The odd nextStreamID is invalid there, so strict HTTP/2 servers (nghttp2) reject the frame as PROTOCOL_ERROR. Since the client has no server-initiated streams (push is off), 0 is correct and accepted by all servers. Fixes golang/go#80759
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
horvathsebin220-sys
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes golang/go#80759
Problem
Client-initiated GOAWAY uses
cc.nextStreamID(odd) as Last-Stream-ID.RFC 9113 §6.8 requires Last-Stream-ID to be in the receiver's stream-id
space — for a client's GOAWAY, that's server-initiated (even) or 0.
Strict servers (nghttp2, Envoy with nghttp2 codec) reject the frame
as PROTOCOL_ERROR.
Fix
Changed
maxStreamID := cc.nextStreamIDtomaxStreamID := uint32(0)insendGoAway(). The client has no server-initiated streams (push is off),so 0 is correct and accepted by all servers.
Testing
odd value too, but 0 is also valid per spec)