internal/http3: limit the size of decoded QPACK field names and values - #261
Open
GOVINSAGA wants to merge 1 commit into
Open
internal/http3: limit the size of decoded QPACK field names and values#261GOVINSAGA wants to merge 1 commit into
GOVINSAGA wants to merge 1 commit into
Conversation
readPrefixedStringWithByte allocates a buffer for a field name or value based on the length encoded on the wire, before reading the string data. The existing check bounds that length by the read limit of the current frame, but a frame length is itself an unbounded QUIC varint, so a peer can declare an arbitrarily large field section in a few bytes and cause a correspondingly large allocation without sending any string data. Reject strings longer than 1 MiB, as HPACK does for HTTP/2. Fixes golang/go#78702 Change-Id: Iedd11405dddcffd416dae7ea7bf3e2fc4ad6a449
Contributor
|
This PR (HEAD: 349d684) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/813820. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readPrefixedStringWithByte allocates a buffer for a field name or value
based on the length encoded on the wire, before reading the string data.
The existing check bounds that length by the read limit of the current
frame, but a frame length is itself an unbounded QUIC varint, so a peer
can declare an arbitrarily large field section in a few bytes and cause
a correspondingly large allocation without sending any string data.
Reject strings longer than 1 MiB, as HPACK does for HTTP/2.
Fixes golang/go#78702