Skip to content

internal/http3: limit the size of decoded QPACK field names and values - #261

Open
GOVINSAGA wants to merge 1 commit into
golang:masterfrom
GOVINSAGA:http3-qpack-string-limit
Open

internal/http3: limit the size of decoded QPACK field names and values#261
GOVINSAGA wants to merge 1 commit into
golang:masterfrom
GOVINSAGA:http3-qpack-string-limit

Conversation

@GOVINSAGA

Copy link
Copy Markdown

readPrefixedStringWithByte allocates a buffer for a field name or value
based on the length encoded on the wire, before reading the string data.

The existing check bounds that length by the read limit of the current
frame, but a frame length is itself an unbounded QUIC varint, so a peer
can declare an arbitrarily large field section in a few bytes and cause
a correspondingly large allocation without sending any string data.

Reject strings longer than 1 MiB, as HPACK does for HTTP/2.

Fixes golang/go#78702

readPrefixedStringWithByte allocates a buffer for a field name or value
based on the length encoded on the wire, before reading the string data.

The existing check bounds that length by the read limit of the current
frame, but a frame length is itself an unbounded QUIC varint, so a peer
can declare an arbitrarily large field section in a few bytes and cause
a correspondingly large allocation without sending any string data.

Reject strings longer than 1 MiB, as HPACK does for HTTP/2.

Fixes golang/go#78702

Change-Id: Iedd11405dddcffd416dae7ea7bf3e2fc4ad6a449
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 349d684) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/813820.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/net/internal/http3: QPACK decoder does not have an allocation limit

2 participants