x/net/idna: fix checking hyphen at 3rd and 4th character - #263
Open
hnakamur wants to merge 1 commit into
Open
Conversation
hnakamur
force-pushed
the
fix_idna_check_hyphen_3rd_4th
branch
from
August 22, 2026 15:56
81f4151 to
1f6b6dd
Compare
Contributor
|
This PR (HEAD: 1f6b6dd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/819700. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/819700. |
Check hyphen restrictions according to Section 4.2.3.1 of RFC 5891. 4.2.3.1. Hyphen Restrictions The Unicode string MUST NOT contain "--" (two consecutive hyphens) in the third and fourth character positions and MUST NOT start or end with a "-" (hyphen). https://www.rfc-editor.org/info/rfc5891/#section-4.2.3.1
hnakamur
force-pushed
the
fix_idna_check_hyphen_3rd_4th
branch
from
August 22, 2026 23:28
1f6b6dd to
84cb650
Compare
Contributor
|
This PR (HEAD: 84cb650) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/819700. Important tips:
|
Contributor
|
Message from Hiroaki Nakamura: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/819700. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check hyphen restrictions according to Section 4.2.3.1 of
RFC 5891.
4.2.3.1. Hyphen Restrictions
The Unicode string MUST NOT contain "--" (two consecutive
hyphens) in the third and fourth character positions and
MUST NOT start or end with a "-" (hyphen).
https://www.rfc-editor.org/info/rfc5891/#section-4.2.3.1
Fixes golang/go#81026