Skip to content

x/net/idna: fix checking hyphen at 3rd and 4th character - #263

Open
hnakamur wants to merge 1 commit into
golang:masterfrom
hnakamur:fix_idna_check_hyphen_3rd_4th
Open

x/net/idna: fix checking hyphen at 3rd and 4th character#263
hnakamur wants to merge 1 commit into
golang:masterfrom
hnakamur:fix_idna_check_hyphen_3rd_4th

Conversation

@hnakamur

@hnakamur hnakamur commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Check hyphen restrictions according to Section 4.2.3.1 of
RFC 5891.

4.2.3.1. Hyphen Restrictions
The Unicode string MUST NOT contain "--" (two consecutive
hyphens) in the third and fourth character positions and
MUST NOT start or end with a "-" (hyphen).

https://www.rfc-editor.org/info/rfc5891/#section-4.2.3.1

Fixes golang/go#81026

@hnakamur
hnakamur force-pushed the fix_idna_check_hyphen_3rd_4th branch from 81f4151 to 1f6b6dd Compare August 22, 2026 15:56
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 1f6b6dd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/819700.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/819700.
After addressing review feedback, remember to publish your drafts!

Check hyphen restrictions according to Section 4.2.3.1 of
RFC 5891.

4.2.3.1.  Hyphen Restrictions
The Unicode string MUST NOT contain "--" (two consecutive
hyphens) in the third and fourth character positions and
MUST NOT start or end with a "-" (hyphen).

https://www.rfc-editor.org/info/rfc5891/#section-4.2.3.1
@hnakamur
hnakamur force-pushed the fix_idna_check_hyphen_3rd_4th branch from 1f6b6dd to 84cb650 Compare August 22, 2026 23:28
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 84cb650) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/819700.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Hiroaki Nakamura:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/819700.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/inet/idna: ToAscii doesn't reject hyphens in positions 3 & 4 when 1 & 2 aren't ascii

2 participants