unix: extend z/OS support by jlee3227 · Pull Request #282 · golang/sys

jlee3227 · 2026-07-02T19:44:50Z

This commit adds the z/OS implementation of ptrace as
well as other minor changes:

Adds new syscall number constants
Refactors code to reduce duplication
A small register optimization

- Adds a ptrace implementation that provides a linux-compatible api as closely as possible - Core ptrace operations are implemented using z/OS's BPX4PTR syscall. Memory operations use PT_READ_BLOCK/PT_WRITE_BLOCK. Register operations use PT_READ_GPR/PT_WRITE_GPR for 64-bit values. - z/OS lacks native single-step support so it is emulated using temporary breakpoints. - Unsupported operations return ENOSYS

Move z/OS LE interaction functions from unix package to runtime package in order to reduce code duplication.

- Changes bpxcall to use R15 instead of R9, reducing register pressure.

gopherbot · 2026-07-02T20:06:04Z

This PR (HEAD: 63d45cb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/796660.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-07-02T20:22:51Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-02T20:22:51Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-27T17:25:00Z

Message from Bill O'Farrell:

Patch Set 1: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-27T17:25:01Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-07-27T16:54:35Z","revision":"4898aa9641dcabb3e92783dc271deb3303703226"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-27T17:25:02Z

Message from Bill O'Farrell:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_11191>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-27T17:25:02Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-27T17:25:03Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-28T15:45:25Z

Message from Joon Lee:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T17:44:08Z

Message from Bill O'Farrell:

Patch Set 2: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T17:44:09Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-19T17:21:55Z","revision":"1a660b08175e0e7de1146d7bc1a3eeb8dfda32e1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T17:44:09Z

Message from Bill O'Farrell:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_11191>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T17:44:10Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_sys-go1.27-linux-amd64 has failed with summary (view all results):

Error: sourceForBranch: gc.Log: rpc error: code = Unavailable desc = bad gateway

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T17:44:10Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T18:01:52Z

Message from Bill O'Farrell:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T18:01:52Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-19T17:30:57Z","revision":"1a660b08175e0e7de1146d7bc1a3eeb8dfda32e1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T18:01:53Z

Message from Bill O'Farrell:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_11191>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T18:01:54Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-19T18:01:54Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-20T19:48:04Z

Message from Joon Lee:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-20T22:57:40Z

Message from Ian Lance Taylor:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

ptrace(request, pid, addr, data uintptr) was passing data to ptracePtr as unsafe.Pointer(data). data carries integer values (signal numbers, register indices, byte counts, target-process addresses) — not Go-managed pointers. Converting an arbitrary uintptr to unsafe.Pointer exposes a synthetic pointer to the garbage collector, which can cause it to crash. Bpx4ptr builds a parms array where parms[3] = &data (pointer to the local copy of the data argument), and BPX4PTR dereferences parms[3] to read the value. The original code stored unsafe.Pointer(data_int) into that local, so BPX4PTR correctly received data_int — but the GC could scan the parms array and mistake data_int for a live heap pointer. Fix by inlining the parms array construction and placing &data at parms[3] directly. BPX4PTR still dereferences parms[3] and obtains the original data integer, but the GC now only sees a valid stack pointer. Also ran `gofmt -w` on all z/OS source files (ptrace_zos.go, ptrace_zos_singlestep.go, syscall_zos_test.go, ztypes_zos_s390x.go) which were not properly formatted. Additionally, copyright year for ptrace_zos.go is now up to date.

gopherbot · 2026-08-24T18:41:13Z

This PR (HEAD: 2723aca) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/796660.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-08-24T19:21:16Z

Message from Joon Lee:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-24T19:21:17Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

ptrace(), ptracePtr(), and ptracePtrWithBuffer() all passed integer values (signal numbers, register indices, byte counts, target-process addresses) to Bpx4ptr as unsafe.Pointer(integer_value). Converting an arbitrary uintptr to unsafe.Pointer is not valid Go: the garbage collector may treat the integer as a heap pointer, attempt to follow it, and crash or corrupt GC state. The fix is the same in all three functions: inline the parms array that Bpx4ptr would construct internally and place &local at the relevant slot. BPX4PTR dereferences parms[N] to read the value, so it receives the integer unchanged, while the GC only ever sees valid stack pointers. ptrace: &data at parms[3] (data uintptr — signal, etc.) ptracePtr: &addr at parms[2] (addr uintptr — target addr) ptracePtrWithBuffer: &addr at parms[2] (same) Addresses reviewer comments df9098da_8b5b0754 (PS2, line 59) and 588f8ca2_e78c1e4e (PS3, line 92) on CL 796660.

gopherbot · 2026-08-25T17:48:31Z

This PR (HEAD: 3f3ff24) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/796660.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-08-25T19:45:25Z

Message from Bill O'Farrell:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-25T19:45:26Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-25T19:16:04Z","revision":"da5283d9412e18c759551655d358879cd1d26004"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-25T19:45:26Z

Message from Bill O'Farrell:

Patch Set 4: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_11191>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-25T19:45:27Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-25T19:45:27Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-25T20:05:45Z

Message from Joon Lee:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-25T22:30:37Z

Message from Ian Lance Taylor:

Patch Set 4: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-25T22:30:38Z

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/796660.
After addressing review feedback, remember to publish your drafts!

jlee3227 added 4 commits July 2, 2026 11:24

unix: add new z/OS syscall numbers

892ef86

unix: refactor z/OS assembly to use runtime implementations

69529a7

Move z/OS LE interaction functions from unix package to runtime package in order to reduce code duplication.

unix: optimize z/OS BPX call register usage

63d45cb

- Changes bpxcall to use R15 instead of R9, reducing register pressure.

Uh oh!

Conversation

jlee3227 commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 2, 2026

Uh oh!

gopherbot commented Jul 2, 2026

Uh oh!

gopherbot commented Jul 2, 2026

Uh oh!

gopherbot commented Jul 27, 2026

Uh oh!

gopherbot commented Jul 27, 2026

Uh oh!

gopherbot commented Jul 27, 2026

Uh oh!

gopherbot commented Jul 27, 2026

Uh oh!

gopherbot commented Jul 27, 2026

Uh oh!

gopherbot commented Jul 28, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 19, 2026

Uh oh!

gopherbot commented Aug 20, 2026

Uh oh!

gopherbot commented Aug 20, 2026

Uh oh!

gopherbot commented Aug 24, 2026

Uh oh!

gopherbot commented Aug 24, 2026

Uh oh!

gopherbot commented Aug 24, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

gopherbot commented Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jlee3227 commented Jul 2, 2026 •

edited

Loading