Skip to content

unix: add missing HWTSTAMP_* constants - #283

Open
cappe987 wants to merge 1 commit into
golang:masterfrom
cappe987:additional-tstamp-flags
Open

unix: add missing HWTSTAMP_* constants#283
cappe987 wants to merge 1 commit into
golang:masterfrom
cappe987:additional-tstamp-flags

Conversation

@cappe987

@cappe987 cappe987 commented Jul 24, 2026 •
edited by tklauser
Loading

Copy link
Copy Markdown

No description provided.

@gopherbot

gopherbot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: bff7dcc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/805700.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@cappe987
cappe987 force-pushed the additional-tstamp-flags branch from bff7dcc to ae9f762 Compare July 25, 2026 08:58
@cappe987 cappe987 changed the title unix: Add hwtstamp tx_types and rx_filters from kernel unix: add hwtstamp tx_types and rx_filters from kernel Jul 25, 2026
@gopherbot

gopherbot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: ae9f762) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/805700.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Message from Casper Andersson:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@tklauser tklauser changed the title unix: add hwtstamp tx_types and rx_filters from kernel unix: add missing HWTSTAMP_* constants Aug 25, 2026
@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from Tobias Klauser:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-25T14:12:32Z","revision":"6d3cc261987db820b1b06dedf9646f853a9b5e44"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

  • LUCI-TryBot-Result-1 has been copied to patch set 3 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-25T14:18:59Z","revision":"58ca03fdfade5f2d892b4408159ae2ef79772b1f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from Tobias Klauser:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_19560>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Message from Dmitri Shuralyov:

Patch Set 3: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cappe987 @gopherbot