unix: keep generated types compilable with current cgo - #285
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I signed it! |
Where struct fp_extended_precision is not declared, cgo -godefs now renders FpExtendedPrecision as _cgopackage.Incomplete, which does not compile. The files generated for those platforms carry an empty struct, so keep producing that.
31ea1c2 to
05487a4
Compare
|
This PR (HEAD: 05487a4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/816660. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
|
Message from Ian Lance Taylor: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-08-18T00:17:41Z","revision":"e4396fcede436c1aa399f4550052df5393272e98"} Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
|
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5206>) Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
|
Message from Ian Lance Taylor: Patch Set 1: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/816660. |
I hit this while regenerating ztypes for a platform that is not in the tree
yet, but it is not specific to that: any regeneration with a current
toolchain runs into it.
Where
struct fp_extended_precisionis not declared,cgo -godefsnowrenders
FpExtendedPrecisionas_cgopackage.Incomplete, and the resultdoes not compile. The committed files for those platforms carry an empty
struct, so this keeps mkpost producing what is already there.
freebsd/arm is unaffected: the C type is declared there, so cgo never emits
Incompletefor it.Happy to widen the scope or drop it if you would rather handle this some
other way.