Skip to content

gopls: support assembly References for labels and asm-only symbols - #664

Open
groot-guo wants to merge 1 commit into
golang:masterfrom
groot-guo:gopls-asm-references
Open

gopls: support assembly References for labels and asm-only symbols#664
groot-guo wants to merge 1 commit into
golang:masterfrom
groot-guo:gopls-asm-references

Conversation

@groot-guo

@groot-guo groot-guo commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Extend textDocument/references in Go assembly files to support control labels, file-local symbols, and symbols without Go declarations.
Control labels are scoped to the enclosing TEXT function, and file-local <> symbols are scoped to their source file.

For golang/go#71754

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 05548a8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/809420.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/809420.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from 郭根源(genyuan):

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/809420.
After addressing review feedback, remember to publish your drafts!

Extend textDocument/references in Go assembly files to support control labels, file-local symbols, and symbols without Go declarations.

Control labels are scoped to the enclosing TEXT function, and file-local <> symbols are scoped to their source file.

For golang/go#71754
@groot-guo
groot-guo force-pushed the gopls-asm-references branch from 05548a8 to 50917c7 Compare August 21, 2026 09:16
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 50917c7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/809420.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants