gopls: support assembly References for labels and asm-only symbols - #664
Open
groot-guo wants to merge 1 commit into
Open
gopls: support assembly References for labels and asm-only symbols#664groot-guo wants to merge 1 commit into
groot-guo wants to merge 1 commit into
Conversation
Contributor
|
This PR (HEAD: 05548a8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/809420. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/809420. |
Contributor
|
Message from 郭根源(genyuan): Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/809420. |
Extend textDocument/references in Go assembly files to support control labels, file-local symbols, and symbols without Go declarations. Control labels are scoped to the enclosing TEXT function, and file-local <> symbols are scoped to their source file. For golang/go#71754
groot-guo
force-pushed
the
gopls-asm-references
branch
from
August 21, 2026 09:16
05548a8 to
50917c7
Compare
Contributor
|
This PR (HEAD: 50917c7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/809420. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend textDocument/references in Go assembly files to support control labels, file-local symbols, and symbols without Go declarations.
Control labels are scoped to the enclosing TEXT function, and file-local <> symbols are scoped to their source file.
For golang/go#71754