go/ssa: preserve single-case receive assignment order - #667
Open
cpunion wants to merge 1 commit into
Open
Conversation
A single-case select is optimized to a simple statement. For a receive assignment, ordinary assignment lowering evaluates the left-hand side before the receive, but select semantics defer it until after the communication. Evaluate the receive before constructing the assignment left-hand side while retaining the existing single-case fast path for all communication forms. Fixes golang/go#80863.
Contributor
|
This PR (HEAD: 3a24a27) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/814560. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single-case select is optimized to a simple statement. For a receive
assignment, ordinary assignment lowering evaluates the left-hand side
before the receive. Select semantics require the receive expression and
communication to happen before the assignment left-hand side is
evaluated.
Evaluate the receive before constructing the assignment left-hand side,
while retaining the existing single-case fast path and SSA shape for the
other communication forms. Add interpreter coverage for both one-result
and two-result receive assignments.
Fixes golang/go#80863.