Skip to content

go/ssa: preserve single-case receive assignment order - #667

Open
cpunion wants to merge 1 commit into
golang:masterfrom
cpunion:select-recv-assign-order-80863
Open

go/ssa: preserve single-case receive assignment order#667
cpunion wants to merge 1 commit into
golang:masterfrom
cpunion:select-recv-assign-order-80863

Conversation

@cpunion

@cpunion cpunion commented Aug 13, 2026

Copy link
Copy Markdown

A single-case select is optimized to a simple statement. For a receive
assignment, ordinary assignment lowering evaluates the left-hand side
before the receive. Select semantics require the receive expression and
communication to happen before the assignment left-hand side is
evaluated.

Evaluate the receive before constructing the assignment left-hand side,
while retaining the existing single-case fast path and SSA shape for the
other communication forms. Add interpreter coverage for both one-result
and two-result receive assignments.

Fixes golang/go#80863.

A single-case select is optimized to a simple statement. For a receive assignment, ordinary assignment lowering evaluates the left-hand side before the receive, but select semantics defer it until after the communication.

Evaluate the receive before constructing the assignment left-hand side while retaining the existing single-case fast path for all communication forms.

Fixes golang/go#80863.
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 3a24a27) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/814560.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/tools/go/ssa: single-case select evaluates receive-assignment LHS too early

2 participants