Skip to content

go/ssa: allow transient untyped integer values - #668

Open
cpunion wants to merge 1 commit into
golang:masterfrom
cpunion:untyped-shift-77067
Open

go/ssa: allow transient untyped integer values#668
cpunion wants to merge 1 commit into
golang:masterfrom
cpunion:untyped-shift-77067

Conversation

@cpunion

@cpunion cpunion commented Aug 13, 2026

Copy link
Copy Markdown

Non-constant untyped integer values may arise transiently while
evaluating shift expressions. The builder already preserves these values,
but the sanity checker rejects them as invalid SSA.

Permit untyped integer instruction results and operands, while retaining
the checks for all other non-constant untyped values. Add examples that
exercise nested, arithmetic, and untyped-rune shift counts.

This follows the conclusion in golang/go#77067 and the specification
clarification tracked by golang/go#77117.

Fixes golang/go#77067.

Non-constant untyped integer values may arise transiently while
evaluating shift expressions. The builder already preserves these values,
but the sanity checker rejects them as invalid SSA.

Permit untyped integer instruction results and operands, while retaining
the checks for all other non-constant untyped values.

Fixes golang/go#77067.
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 23534d6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/814580.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 1: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 1: TryBot-Bypass+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Jie Li:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 1: -TryBot-Bypass


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 1: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-20T17:10:57Z","revision":"b595bab0c32c620595bdc93823749e9bd02a26f3"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_7392>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/814580.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/tools/go/ssa: SanityCheckFunctions fails on non-constant shift with untyped constant left operand

2 participants